Skip site navigation (1) Skip section navigation (2)

Re: Problematic dependency in plpython Makefile [Windows]

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Problematic dependency in plpython Makefile [Windows]
Date: 2013-01-03 04:58:10
Message-ID: 50E50FE2.5040701@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers
On 01/02/2013 11:34 PM, Andrew Dunstan wrote:
>
> On 01/02/2013 10:13 PM, Noah Misch wrote:
>> On Windows, src/pl/plpython/Makefile has a rule whose target line 
>> expands to
>> something like "python33.def: C:/Windows/system32/python33.dll".  
>> When doing a
>> MinGW build with Cygwin's make-3.81, that line elicits an error:
>>
>> Makefile:69: *** target pattern contains no `%'.  Stop.
>>
>> Seeing a second colon, make treats the line as a static pattern 
>> rule.  Perhaps
>> the MinGW project ships a make patched to avoid this, or perhaps folks
>> building PostgreSQL override WINDIR.  In any event, that dependency 
>> is not
>> useful: we can't build the named file if it's absent, and an error from
>> pexports is a good as an error from make.  Let's drop the dependency.
>>
>> Note that this affects --without-python builds during "make clean".
>>
>>
>>
>
> I suspect under Msys the path seen won't contain a colon - it will be 
> an Msys virtualized path like /c/Windows/system32/....

Apparently not, from testing. Maybe the make is patched after all.

cheers

andrew





In response to

pgsql-hackers by date

Next:From: Hitoshi HaradaDate: 2013-01-03 06:13:47
Subject: Re: multiple CREATE FUNCTION AS items for PLs
Previous:From: Andrew DunstanDate: 2013-01-03 04:34:36
Subject: Re: Problematic dependency in plpython Makefile [Windows]

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group