Skip site navigation (1) Skip section navigation (2)

Big disconnect_and_exit cleanup in pg_basebackup

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
Subject: Big disconnect_and_exit cleanup in pg_basebackup
Date: 2013-01-02 16:17:59
Message-ID: 50E45DB7.3020306@cybertec.at (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi,

the previously sent "factor out pg_malloc and friends" patch
may call exit() in case of OOM during allocation and as a consequence,
PQfinish() won't get called, leaving an "unexpected EOF from client"
in the log.

Let's close this annoyance in pg_basebackup. The attached patch does
the following:

- adds a PQfinish() (actually PQfinishSafe()) call that was just posted
   in another thread
- replace all PQfinish() and PQclear() with their *Safe counterpart so
   a normal execution won't result in a crash because of calling PQfinish()
   on a stale pointer
- kill the disconnect_and_exit() macro, replace it with plain exit(),
   the atexit callback does the disconnect anyway.

Best regards,
Zoltán Böszörményi

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
      http://www.postgresql.at/


Attachment: pg_basebackup-disconnect-on-exit-cleanup-v2.patch
Description: text/x-patch (17.9 KB)

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2013-01-02 16:20:21
Subject: Re: Minor fix in 'clean' action of 'src/backend/Makefile'
Previous:From: Fabrízio de Royes MelloDate: 2013-01-02 16:05:17
Subject: Minor fix in 'clean' action of 'src/backend/Makefile'

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group