Skip site navigation (1) Skip section navigation (2)

Re: Overlength socket paths (was Re: [COMMITTERS] pgsql: Refactor flex and bison make rules)

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeremy Drake <pgbuildfarm(at)jdrake(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Overlength socket paths (was Re: [COMMITTERS] pgsql: Refactor flex and bison make rules)
Date: 2012-11-29 23:31:23
Message-ID: 50B7F04B.3080009@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On 11/29/2012 06:23 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> ... Or maybe the
>> postmaster needs to check the length somehow before it calls
>> StreamServerPort() so we can give a saner error message.
> Hm.  That's ugly, but a lot less invasive than trying to get the
> official API to pass the information through.  Sounds like a plan to me.
>
> However, that's only addressing the reporting end of it; I think we
> also need to change the pg_upgrade test script as suggested by Noah.
>
> 			

The test script doesn't do anything. It's pg_upgrade itself that sets 
the socket dir. See option.c:get_sock_dir()

cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Merlin MoncureDate: 2012-11-29 23:34:02
Subject: Re: json accessors
Previous:From: Tom LaneDate: 2012-11-29 23:23:08
Subject: Re: Overlength socket paths (was Re: [COMMITTERS] pgsql: Refactor flex and bison make rules)

pgsql-committers by date

Next:From: Simon RiggsDate: 2012-11-29 23:53:31
Subject: pgsql: Correctly init/deinit recovery xact environment.
Previous:From: Tom LaneDate: 2012-11-29 23:23:08
Subject: Re: Overlength socket paths (was Re: [COMMITTERS] pgsql: Refactor flex and bison make rules)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group