Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Refactor flex and bison make rules

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeremy Drake <pgbuildfarm(at)jdrake(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Refactor flex and bison make rules
Date: 2012-11-29 16:17:44
Message-ID: 50B78AA8.6090103@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On 11/28/2012 11:03 PM, Tom Lane wrote:
> Jeremy Drake <pgbuildfarm(at)jdrake(dot)com> writes:
>> While we're talking about odd issues that only seem to happen on Okapi,
>> does anyone know of anything I can do to diagnose the pg_upgrade failure
>> on the 9.2 branch?  There are no rogue (non-buildfarm-related)
>> postmaster/postgres processes running on the machine.
> [ digs around ... ]  It looks like the failure is coming from here:
>
> 	if (strlen(path) >= sizeof(unp->sun_path))
> 		return EAI_FAIL;
>
> What's the size of the sun_path member of struct sockaddr_un on your
> machine?  I count 115 characters in your socket path ... maybe you
> just need a less deeply nested test directory.
>
> (If that is the problem, seems like we need to return something
> more helpful than EAI_FAIL here.)
>
> 			

Looks like it was. Good catch. What's the best way to fix?

Note that this problem was triggered by having a buildfarm buildroot 
path of length about 49 or 50. I'm lucky not to have triggered it 
myself. Do I need to add a check to limit the buildroot path length?

cheers

andrew


In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-11-29 16:31:30
Subject: Overlength socket paths (was Re: [COMMITTERS] pgsql: Refactor flex and bison make rules)
Previous:From: Robert HaasDate: 2012-11-29 16:17:41
Subject: Re: [PATCH] binary heap implementation

pgsql-committers by date

Next:From: Tom LaneDate: 2012-11-29 16:31:30
Subject: Overlength socket paths (was Re: [COMMITTERS] pgsql: Refactor flex and bison make rules)
Previous:From: Robert HaasDate: 2012-11-29 16:17:22
Subject: pgsql: Basic binary heap implementation.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group