Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Refactor flex and bison make rules

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org, Jeremy Drake <pgbuildfarm(at)jdrake(dot)com>
Subject: Re: pgsql: Refactor flex and bison make rules
Date: 2012-11-28 20:47:56
Message-ID: 50B6787C.90209@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On 11/28/2012 02:14 PM, Alvaro Herrera wrote:
> Peter Eisentraut wrote:
>> Refactor flex and bison make rules
>>
>> Numerous flex and bison make rules have appeared in the source tree
>> over time, and they are all virtually identical, so we can replace
>> them by pattern rules with some variables for customization.
> Okapi has been failing sporadically on ecpg, and I wonder if it's
> related to this change.  See, for example,
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=okapi&dt=2012-11-28%2018%3A15%3A01
>
> icc -O3 -xSSSE3 -parallel -ip -mp1 -fno-strict-aliasing -g -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -DECPG_COMPILE -I../include -I../../../../src/interfaces/ecpg/include -I. -I. -DMAJOR_VERSION=4 -DMINOR_VERSION=9 -DPATCHLEVEL=0 -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/et  -c -o parser.o parser.c
> icc -O3 -xSSSE3 -parallel -ip -mp1 -fno-strict-aliasing -g -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -DECPG_COMPILE -I../include -I../../../../src/interfaces/ecpg/include -I. -I. -DMAJOR_VERSION=4 -DMINOR_VERSION=9 -DPATCHLEVEL=0 -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/et  -c -o keywords.o keywords.c
> parser.c(25): catastrophic error: could not open source file "preproc.h"
>    #include "preproc.h"
>                        ^
>
> compilation aborted for parser.c (code 4)
> make[4]: *** [parser.o] Error 4
> make[4]: *** Waiting for unfinished jobs....
> keywords.c(20): catastrophic error: could not open source file "preproc.h"
>    #include "preproc.h"
>                        ^
>
> compilation aborted for keywords.c (code 4)


Well, it looks like the make is broken and missing a clear dependency 
requirement. I think we need to ask Jeremy to turn off parallel build 
for okapi.


cheers

andrew


In response to

Responses

pgsql-hackers by date

Next:From: Jeff JanesDate: 2012-11-28 21:00:52
Subject: Re: PITR potentially broken in 9.2
Previous:From: Andrew DunstanDate: 2012-11-28 20:44:09
Subject: Re: json accessors

pgsql-committers by date

Next:From: Tom LaneDate: 2012-11-28 23:01:38
Subject: Re: pgsql: Refactor flex and bison make rules
Previous:From: Alvaro HerreraDate: 2012-11-28 19:14:19
Subject: Re: pgsql: Refactor flex and bison make rules

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group