Re: plpgsql_check_function - rebase for 9.3

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Selena Deckelmann <selena(at)chesnok(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: plpgsql_check_function - rebase for 9.3
Date: 2012-10-07 15:39:15
Message-ID: 5071A223.6030209@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 10/07/2012 11:25 AM, Tom Lane wrote:
> Selena Deckelmann <selena(at)chesnok(dot)com> writes:
>> This also represents my inaugural use of pg_bsd_indent. I ran it on
>> pl_check.c - which made things mostly better. Happy to try and fix it
>> up more if someone can explain to me what (if anything) I did
>> incorrectly when using it.
> It looks like you didn't give it a typedef list? Fetch the file from
> http://buildfarm.postgresql.org/cgi-bin/typedefs.pl
> and pass it with --typedefs=filename. If you're dealing with something
> that adds new typedef names, you can add them to the list file manually.
>
>

You's not supposed to be calling pg_bsd_indent directly at all. You's
supposed to be calling pgindent - it will call pg_bsd_indent as needed
and adjust the results. See src/tools/pgindent/README.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-10-07 17:27:45 Rethinking placement of latch self-pipe initialization
Previous Message Andrew Dunstan 2012-10-07 15:33:38 windows warnings