windows warnings

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: windows warnings
Date: 2012-10-07 15:33:38
Message-ID: 5071A0D2.5010603@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I have just noticed the following warnings on currawong (MSVC):

"d:\bf\root\HEAD\pgsql.1748\pgsql.sln" (default target) (1) ->
(postgres target) ->
.\src\backend\utils\adt\array_selfuncs.c(574): warning C4305: '=' : truncation from 'double' to 'float4'
.\src\backend\optimizer\path\costsize.c(1911): warning C4013: '_isnan' undefined; assuming extern returning int
d:\bf\root\head\pgsql.1748\src\backend\catalog\objectaddress.c(1363): warning C4715: 'get_object_property_data' : not all control paths return a value

"d:\bf\root\HEAD\pgsql.1748\pgsql.sln" (default target) (1) ->
(interfaces\libecpg target) ->
d:\bf\root\head\pgsql.1748\src\interfaces\ecpg\ecpglib\typename.c(68): warning C4715: 'ecpg_type_name' : not all control paths return a value

I think we can fix the first by doing a cast to float4, the second by
#including float.h, and the third and fourth by adding return statements
at the bottom of the functions which won't in fact ever be reached. but
should keep the compiler happy.

There are also a bunch of warnings like this from the python include
files that I guess we can't do much about, unfortunately (it's
re-typdefing ssize_t):

"d:\bf\root\HEAD\pgsql.1748\pgsql.sln" (default target) (1) ->
(PLs\plpython2 target) ->
c:\python27\include\pyconfig.h(201): warning C4142: benign redefinition of type

cheers

andrew

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2012-10-07 15:39:15 Re: plpgsql_check_function - rebase for 9.3
Previous Message Tom Lane 2012-10-07 15:29:49 Re: Regarding identifying a foreign scan