Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Silence compiler warning about pointer type mismatch on some pla

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Silence compiler warning about pointer type mismatch on some pla
Date: 2012-10-02 17:01:30
Message-ID: 506B1DEA.4070904@vmware.com (view raw or flat)
Thread:
Lists: pgsql-committers
On 02.10.2012 19:33, Fujii Masao wrote:
> On Tue, Oct 2, 2012 at 11:47 PM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)iki(dot)fi>  wrote:
>> Silence compiler warning about pointer type mismatch on some platforms.
>>
>> timeval.t_sec is of type time_t, which is not always compatible with long.
>> I'm not sure if this was just harmless warning or a real bug, but this
>> fixes it, anyway.
>
> +				timeout.tv_sec = usecs;
>
> This code looks like a bug. No? I think the attached patch should be applied.

Sigh, yes. Thanks for paying more attention than me..

- Heikki


In response to

pgsql-committers by date

Next:From: Fujii MasaoDate: 2012-10-02 18:12:04
Subject: Re: pgsql: Split off functions related to timeline history files and XLOG a
Previous:From: Heikki LinnakangasDate: 2012-10-02 17:00:50
Subject: pgsql: Fix typo in previous warning-silencing patch.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group