Skip site navigation (1) Skip section navigation (2)

Re: little patch for "Detect serial columns from pg_depend" and bugfix

From: Quan Zongliang <quanzongliang(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: little patch for "Detect serial columns from pg_depend" and bugfix
Date: 2012-09-06 00:56:56
Message-ID: 5047F4D8.7070302@gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On 2012/9/5 22:48, 权宗亮 wrote:
>
>
> 2012/9/5 Dave Page <dpage(at)pgadmin(dot)org <mailto:dpage(at)pgadmin(dot)org>>
>
>     On Wed, Sep 5, 2012 at 3:39 AM, Quan Zongliang
>     <quanzongliang(at)gmail(dot)com <mailto:quanzongliang(at)gmail(dot)com>> wrote:
>     >
>     > new patch attched.
>     > I tested it under Cygwin, seems OK.
>
>     I got an error on my first test I'm afraid :-(
>
>     2012-09-05 14:39:41 QUERY : Set query (localhost:5432): SELECT classid
>     FROM pg_depend
>     WHERE refobjid=207478::oid AND refobjsubid = 1 AND objid IN
>     ('pem.agent_id_seq'::regclass,'"pem.agent_id_seq"'::regclass) AND
>     deptype='a'
>     2012-09-05 14:39:41 ERROR : ERROR: relation "pem.agent_id_seq"
>     does not exist
>     LINE 3: ...id = 1 AND objid IN
>     ('pem.agent_id_seq'::regclass,'"pem.agen...
>
>     How does the attached version of the patch look? I've tweaked the
>     formatting and removed the excess quotes that seemed to be causing the
>     issue.
>
>     --
>     Dave Page
>     Blog: http://pgsnake.blogspot.com
>     Twitter: @pgsnake
>
>     EnterpriseDB UK: http://www.enterprisedb.com
>     The Enterprise PostgreSQL Company
>
>
> There is a bug in original source.
> I will try to fix it tomorrow.
>
> When a column is given a special name.
> The serial type can not be reversed correctly.
>
> defination: "c 2" bigserial
> display in pgAdmin: "c 2" bigint NOT NULL DEFAULT nextval('pem."t1_c 
> 2_seq"'::regclass)
>
> Because pgAdmin check columns which default value has 'pem.t1_c 
> 2_seq'::regclass
> and '"pem.t1_c 2_seq"'::regclass. But second one should be 'pem."t1_c 
> 2_seq"'::regclass
>
> Quan Zongliang

Try this.
Only fixed for 8.1 and above.

Attachment: pgColumn.zip
Description: application/octet-stream (982 bytes)

In response to

Responses

pgadmin-hackers by date

Next:From: Alexander LawDate: 2012-09-06 07:30:12
Subject: pgAdmin Website Russian Translation
Previous:From: pgAdmin TracDate: 2012-09-05 21:15:14
Subject: Re: [pgAdmin III] #377: Regression in 1.16 b4: missing items from context menu for indexes and pkeys

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group