| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: [WIP] plpgsql is not translate-aware |
| Date: | 2008-10-09 04:55:01 |
| Message-ID: | 5015.1223528101@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> So this'd seem to be the version ready to be applied (plus the needed
> nls.mk files).
I'm down to two seriously trivial nitpicks:
* "preferably" has one r.
> + const char *domain; /* message domain, NULL if default */
This comment is incorrect, since the field value is not actually
intended to ever be NULL.
But you need Peter's advice before going further, because I don't
actually know a darn thing about the NLS infrastructure.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ryan Bradetich | 2008-10-09 05:39:00 | [WIP] Reduce alignment requirements on 64-bit systems. |
| Previous Message | Pavel Stehule | 2008-10-09 03:24:25 | Re: WITH RECURSIVE ... simplified syntax? |