Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule.
Date: 2012-07-20 20:17:08
Message-ID: 500.1342815428@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Remove prepared transactions from main isolation test schedule.

> There is no point in running this test when prepared transactions are disabled,
> which is the default. New make targets that include the test are provided. This
> will save some useless waste of cycles on buildfarm machines.

Having done that, shouldn't we remove prepared-transactions_1.out (the
"expected" file for the prepared-transactions-disabled case)?

Having a megabyte-sized test file for that case has always seemed pretty
wasteful to me.  Now that the test won't be run unless intentionally
selected, it seems like people who are using it would expect it to
actually test prepared transactions --- so having it "pass" when they're
disabled seems wrong.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2012-07-20 20:21:35
Subject: Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule.
Previous:From: Tom LaneDate: 2012-07-20 20:12:05
Subject: Re: CHECK NO INHERIT syntax

pgsql-committers by date

Next:From: Andrew DunstanDate: 2012-07-20 20:21:35
Subject: Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule.
Previous:From: Andrew DunstanDate: 2012-07-20 20:04:35
Subject: pgsql: Remove prepared transactions from main isolation test schedule.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group