Skip site navigation (1) Skip section navigation (2)

Re: Re: Call for platforms

From: Mark Knox <segfault(at)hardline(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: Call for platforms
Date: 2001-03-29 02:16:32
Message-ID: 5.0.2.1.0.20010328205126.009ea190@core.hardline.org (view raw or flat)
Thread:
Lists: pgsql-hackers
At 12:27 AM 3/28/01 -0500, Tom Lane wrote:

>That would fix it for ARM but not for anyplace else with similar
>alignment behavior.  Would you try this patch instead to see what
>happens?

I don't think this solution would be valid on many other platforms. It forces the structure to not be padded, and assumes that the cpu will be able to fetch from unaligned boundaries. The only reason this works is that the arm linux kernel contains an alignment trap handler that catches the fault and does a fixup on the access. Otherwise it would crash with SIGBUS.

>  static FormData_pg_attribute a1 = {
>!       0xffffffff, {"ctid"}, TIDOID, 0, SizeOfIptrData,
>        SelfItemPointerAttributeNumber, 0, -1, -1, '\0', 'p', '\0', 'i', '\0', '\0'
>  }; 

Well, this patch seems to produce attlens of 6 as desired, but it causes many (13) of the regression tests to fail. Do you want to see the regression.diffs? 


In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2001-03-29 04:06:42
Subject: Re: Re: Call for platforms
Previous:From: Justin CliftDate: 2001-03-29 01:46:55
Subject: [Fwd: Delayed release of OpenSSL 0.9.6a beta 3]

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group