Skip site navigation (1) Skip section navigation (2)

Re: 9.2beta1 regression: pg_restore --data-only does not set sequence values any more

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Martin Pitt <mpitt(at)debian(dot)org>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 9.2beta1 regression: pg_restore --data-only does not set sequence values any more
Date: 2012-05-21 18:59:34
Message-ID: 4FBA9096.30107@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers

On 05/16/2012 10:23 AM, Andrew Dunstan wrote:
>
>
> On Wed, May 16, 2012 at 9:08 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us 
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>
>     Martin Pitt <mpitt(at)debian(dot)org <mailto:mpitt(at)debian(dot)org>> writes:
>     > while packaging 9.2 beta 1 for Debian/Ubuntu the postgresql-common
>     > test suite noticed a regression: It seems that pg_restore
>     --data-only
>     > now skips the current value of sequences, so that in the upgraded
>     > database the sequence counter is back to the default.
>
>     I believe this is a consequence of commit
>     a4cd6abcc901c1a8009c62a27f78696717bb8fe1, which introduced the
>     entirely
>     false assumption that --schema-only and --data-only have something to
>     do with the order that entries appear in the archive ...
>
>
>
> Darn, will investigate.
>
>

[cc -hackers]

Well, the trouble is that we have these pesky SECTION_NONE entries for 
things like comments, security labels and ACLs that need to be dumped in 
the right section, so we can't totally ignore the order. But we could 
(and probably should) ignore the order for making decisions about 
everything BUT those entries.

So, here's a revised plan:

     --section=data will dump exactly TABLE DATA, SEQUENCE SET or BLOBS 
entries
     --section=pre-data will dump SECTION_PRE_DATA items (other than 
SEQUENCE SET) plus any immediately following SECTION_NONE items.
     --section=post-data will dump everything else.

Comments?


cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Stephen FrostDate: 2012-05-21 19:15:25
Subject: Re: heap metapages
Previous:From: Tom LaneDate: 2012-05-21 18:37:31
Subject: Re: transformations between types and languages

pgsql-bugs by date

Next:From: edivenDate: 2012-05-21 19:04:47
Subject: BUG #6657: Documentation bug for PQconnectdbParams
Previous:From: mwDate: 2012-05-21 18:38:29
Subject: BUG #6656: Wrong timestamptz + interval calculation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group