Skip site navigation (1) Skip section navigation (2)

Re: Patch pg_is_in_backup()

From: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch pg_is_in_backup()
Date: 2012-05-15 00:52:32
Message-ID: 4FB1A8D0.4080306@dalibo.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Sorry for the the double post but it seems that my previous reply
doesn't reach the pgsql-hacker list. So here is the new patches that
limit lines to 80 characters.

Regards,

Le 02/05/2012 19:53, Gabriele Bartolini a écrit :
> Hi Gilles,
>
>    Sorry for the delay.
>
> Il 03/04/12 14:21, Gilles Darold ha scritto:
>> +1, this is also my point of view.
>
>    I have looked at the patch that contains both pg_is_in_backup() and
> pg_backup_start_time().
>
>    From a functional point of view it looks fine to me. I was thinking
> of adding the BackupInProgress() at the beginning of
> pg_backup_start_time(), but the AllocateFile() function already make
> sure the file exists.
>
>    I have performed some basic testing of both functions and tried to
> inject invalid characters in the start time field of the backup_label
> file and it is handled (with an exception) by the server. Cool.
>
>    I spotted though some formatting issues, in particular indentation
> and multi-line comments. Some rows are longer than 80 chars.
>
>    Please resubmit with these cosmetic changes and it is fine with me.
> Thank you.
>
> Cheers,
> Gabriele
>


-- 
Gilles Darold
Administrateur de bases de données
http://dalibo.com - http://dalibo.org


Attachment: postgresql-pg_is_in_backup-patch-v4.diff
Description: text/x-patch (3.0 KB)
Attachment: postgresql-pg_backup_start_time-pg_is_in_backup-patch-v4.diff
Description: text/x-patch (5.4 KB)
Attachment: postgresql-pg_backup_start_time-patch-v4.diff
Description: text/x-patch (4.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-05-15 02:43:35
Subject: Re: Bugs in our Windows socket code
Previous:From: Simon RiggsDate: 2012-05-14 23:31:20
Subject: Re: Re: [COMMITTERS] pgsql: Ensure age() returns a stable value rather than the latest value

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group