Re: Patch: add conversion from pg_wchar to multibyte

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Erik Rijkers" <er(at)xs4all(dot)nl>
Cc: <aekorotkov(at)gmail(dot)com>,<pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: add conversion from pg_wchar to multibyte
Date: 2012-04-30 21:48:31
Message-ID: 4F9EC25F02000025000475F7@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> Hopefully that's not too hard to fix; the basic approach seems
> quite promising.

After playing with trigram searches for name searches against copies
of production database with appropriate indexing, our shop has
chosen it as the new way to do name searches here. It's really
nice.

My biggest complaint is related to setting the threshold for the %
operator. It seems to me that there should be a GUC to control the
default, and that there should be a way to set the threshold for
each % operator in a query (if there is more than one). The
function names which must be used on the connection before running
the queries don't give any clue that they are related to trigrams:
show_limit() and set_limit() are nearly useless for conveying the
semantics of what they do.

Even with those issues, trigram similarity searching is IMO one of
the top five coolest things about PostgreSQL and should be promoted
heavily.

-Kevin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2012-04-30 22:43:46 Re: Future In-Core Replication
Previous Message Merlin Moncure 2012-04-30 21:35:04 Re: Future In-Core Replication