Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.
Date: 2012-03-31 16:52:37
Message-ID: 4F773655.30004@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers

On 03/31/2012 11:59 AM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net>  writes:
>> On 03/31/2012 10:56 AM, Tom Lane wrote:
>>> Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.
>>>
>>> Per buildfarm, this is now needed by contrib/pg_stat_statements.
>> It seems to have broken mingw earlier now :-(
> Ugh.  It looks like ecpg (and also pg_dump) are defining symbols named
> ScanKeywords and NumScanKeywords, but relying on the backend's
> keywords.h to provide global declarations for those.  And this doesn't
> work once we PGDLLIMPORT-decorate those declarations.
>
> The only simple fix I can see is to rename the symbols in ecpg and
> pg_dump to something else.  This is probably a good thing anyway to
> reduce confusion.  Anybody have another idea?
>
> 			

Seems the sane thing to do.

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-03-31 17:17:12
Subject: Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.
Previous:From: Tom LaneDate: 2012-03-31 16:35:53
Subject: Re: pg_dump incredibly slow dumping a single schema from a large db

pgsql-committers by date

Next:From: Tom LaneDate: 2012-03-31 17:16:04
Subject: pgsql: Rename frontend keyword arrays to avoid conflict with backend.
Previous:From: Tom LaneDate: 2012-03-31 15:59:47
Subject: Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group