Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Improve the -l (limit) option recently added to contrib/vacuumlo

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>, Robert Haas <robert(dot)haas(at)enterprisedb(dot)com>
Subject: Re: [COMMITTERS] pgsql: Improve the -l (limit) option recently added to contrib/vacuumlo
Date: 2012-03-21 07:10:28
Message-ID: 4F697EE4.6090308@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On 21.03.2012 01:05, Tom Lane wrote:
> Improve the -l (limit) option recently added to contrib/vacuumlo.
>
> Instead of just stopping after removing an arbitrary subset of orphaned
> large objects, commit and start a new transaction after each -l objects.
> This is just as effective as the original patch at limiting the number of
> locks used, and it doesn't require doing the OID collection process
> repeatedly to get everything.  Since the option no longer changes the
> fundamental behavior of vacuumlo, and it avoids a known server-side
> limitation, enable it by default (with a default limit of 1000 LOs per
> transaction).
>
> In passing, be more careful about properly quoting the names of tables
> and fields, and do some other cosmetic cleanup.

Shouldn't this be backported? Without it, vacuumlo is effectively broken 
in 9.0 and 9.1.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2012-03-21 07:11:40
Subject: Re: Chronic performance issue with Replication Failover and FSM.
Previous:From: Ashutosh BapatDate: 2012-03-21 06:43:14
Subject: Reconstructing Insert queries with indirection

pgsql-committers by date

Next:From: Tom LaneDate: 2012-03-21 13:54:53
Subject: Re: [COMMITTERS] pgsql: Improve the -l (limit) option recently added to contrib/vacuumlo
Previous:From: Robert HaasDate: 2012-03-21 01:26:54
Subject: pgsql: Add some CHECK_FOR_INTERRUPTS() calls to the heap-sort callpath

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group