Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Make group commit more effective.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Make group commit more effective.
Date: 2012-01-30 22:20:15
Message-ID: 4F27179F.4010401@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On 30.01.2012 23:06, Heikki Linnakangas wrote:
> On 30.01.2012 22:50, Heikki Linnakangas wrote:
>> On 30.01.2012 20:27, Robert Haas wrote:
>>> Either this patch, or something else committed this morning, is
>>> causing "make check" to hang or run extremely slowly for me. I think
>>> it's this patch, because I attached to a backend and stopped it a few
>>> times, and all the backtraces look like this:
>>
>> Yeah, sure looks like it's the group commit commit. It works for me, and
>> staring at the code, I have no idea what could be causing it. The
>> buildfarm seems happy too, so this is pretty mysterious.
>
> And just after sending that, I succeeded to reproduce this. I had to
> lower wal_buffers to a small value to make it happen. I'm debugging this
> now..

It was a bug in the LWLockRelease code, after all. Fixed. Unfortunately 
this added a couple more instructions to that critical codepath, but I 
think it should still go without notice. Let me know if this doesn't fix 
the hang on your laptop.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

pgsql-hackers by date

Next:From: Adrian KlaverDate: 2012-01-30 22:20:24
Subject: Re: pg_dump -s dumps data?!
Previous:From: Euler Taveira de OliveiraDate: 2012-01-30 21:14:05
Subject: Re: Patch pg_is_in_backup()

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2012-01-31 08:41:20
Subject: pgsql: Print function signature, not just name,in PL/pgSQL error messa
Previous:From: Heikki LinnakangasDate: 2012-01-30 22:16:38
Subject: pgsql: Fix bug in the new wait-until-lwlock-is-free mechanism.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group