Skip site navigation (1) Skip section navigation (2)

Re: Group commit, revised

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <peter(at)2ndquadrant(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Group commit, revised
Date: 2012-01-30 15:32:01
Message-ID: 4F26B7F1.2000004@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On 30.01.2012 17:18, Simon Riggs wrote:
> On Mon, Jan 30, 2012 at 2:57 PM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com>  wrote:
>
>> I committed this. I ran pgbench test on an 8-core box and didn't see any
>> slowdown. It would still be good if you get a chance to rerun the bigger
>> test, but I feel confident that there's no measurable slowdown.
>
> I asked clearly and specifically for you to hold back committing
> anything. Not sure why you would ignore that and commit without
> actually asking myself or Peter. On a point of principle alone, I
> think you should revert. Working together is difficult if
> communication channels are openly ignored and disregarded.

You must be referring to this:

http://archives.postgresql.org/pgsql-hackers/2012-01/msg01406.php

What I committed in the end was quite different from the version that 
was in reply to, too. If you have a specific objection to the patch as 
committed, please let me know.

> Peter and I have been working on a new version that seems likely to
> improve performance over your suggestions. We should be showing
> something soon.

Please post those ideas, and let's discuss them. If it's something 
simple, maybe we can still sneak them into this release. Otherwise, 
let's focus on the existing patches that are pending review or commit.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Adrian KlaverDate: 2012-01-30 15:34:49
Subject: Re: pg_dump -s dumps data?!
Previous:From: Robert HaasDate: 2012-01-30 15:26:05
Subject: Re: 16-bit page checksums for 9.2

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group