Skip site navigation (1) Skip section navigation (2)

Re: Group commit, revised

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Geoghegan <peter(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Group commit, revised
Date: 2012-01-30 14:57:27
Message-ID: 4F26AFD7.8040808@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On 27.01.2012 15:38, Robert Haas wrote:
> On Fri, Jan 27, 2012 at 8:35 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com>  wrote:
>> Yeah, we have to be careful with any overhead in there, it can be a hot
>> spot. I wouldn't expect any measurable difference from the above, though.
>> Could I ask you to rerun the pgbench tests you did recently with this patch?
>> Or can you think of a better test for this?
>
> I can't do so immediately, because I'm waiting for Nate Boley to tell
> me I can go ahead and start testing on that machine again.  But I will
> do it once I get the word.

I committed this. I ran pgbench test on an 8-core box and didn't see any 
slowdown. It would still be good if you get a chance to rerun the bigger 
test, but I feel confident that there's no measurable slowdown.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2012-01-30 15:03:09
Subject: Re: Multithread Query Planner
Previous:From: Heikki LinnakangasDate: 2012-01-30 14:55:07
Subject: pgsql: Make group commit more effective.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group