Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Date: 2012-01-15 21:21:53
Message-ID: 4F134371.7070305@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers

On 01/13/2012 07:09 PM, Alex Hunsaker wrote:
> On Fri, Jan 13, 2012 at 16:07, Andrew Dunstan<andrew(at)dunslane(dot)net>  wrote:
>>
>> On 01/12/2012 09:28 PM, Alex Hunsaker wrote:
>>> Util.c/o not depending on plperl_helpers.h was also throwing me for a loop
>>> so I fixed it and SPI.c... Thoughts?
>>
>> Basically looks good, but I'm confused by this:
>>
>>    do language plperl $$ elog('NOTICE', ${^TAINT}); $$;
>>
>>
>>
>> Why is NOTICE quoted here? It's constant that we've been careful to set up.
> No reason.
>
> [ Err well It was just part of me flailing around while trying to
> figure out why elog was still crashing even thought I had the issue
> fixed. The real problem was Util.o was not being recompiled due to
> Util.c not depending on plperl_helpers.h) ]


Except that it doesn't work. The above produces no output in the 
regression tests.


I've committed it with that changed and result file changed accordingly.

cheers

andrew

In response to

pgsql-hackers by date

Next:From: Jeff JanesDate: 2012-01-15 21:46:30
Subject: Re: Standalone synchronous master
Previous:From: Heikki LinnakangasDate: 2012-01-15 21:17:54
Subject: Re: Vacuum rate limit in KBps

pgsql-committers by date

Next:From: Fujii MasaoDate: 2012-01-16 01:44:14
Subject: Re: pgsql: Correctly initialise shared recoveryLastRecPtr in recovery.
Previous:From: Andrew DunstanDate: 2012-01-15 21:21:44
Subject: pgsql: Improve efficiency of recent changes to plperl's sv2cstr().

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group