Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Date: 2012-01-13 23:07:43
Message-ID: 4F10B93F.2080008@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers

On 01/12/2012 09:28 PM, Alex Hunsaker wrote:
> Util.c/o not depending on plperl_helpers.h was also throwing me for a 
> loop so I fixed it and SPI.c... Thoughts? 

Basically looks good, but I'm confused by this:

    do language plperl $$ elog('NOTICE', ${^TAINT}); $$;



Why is NOTICE quoted here? It's constant that we've been careful to set up.

cheers

andrew


In response to

Responses

pgsql-hackers by date

Next:From: Kevin GrittnerDate: 2012-01-13 23:18:50
Subject: Re: Remembering bug #6123
Previous:From: Tomas VondraDate: 2012-01-13 23:07:02
Subject: Re: Review of: explain / allow collecting row counts without timing info

pgsql-committers by date

Next:From: Alex HunsakerDate: 2012-01-14 00:09:17
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Previous:From: Alvaro HerreraDate: 2012-01-13 18:46:10
Subject: Re: pgsql: Typo fix.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group