On 13.1.2012 18:07, Josh Berkus wrote:
> Eric's review follows:
> 
> Compiling on Ubuntu 10.04 LTS AMD64 on a GoGrid virtual machine from
> 2012-01-12 git checkout.
> 
> Patch applied fine.
> 
> 'make check' results in failures when this patch is put into place.
> 
> ========================
>  6 of 128 tests failed.
> ========================
> 
> Here are the relevant failures.
> 
> parallel group (2 tests):  create_view create_index
>      create_index             ... FAILED
> parallel group (9 tests):  create_cast create_aggregate drop_if_exists
> typed_table vacuum constraints create_table_like triggers inherit
>      inherit                  ... FAILED
> parallel group (20 tests):  select_distinct_on btree_index update random
> select_distinct select_having namespace delete case hash_index union
> select_implicit select_into transactions portals subselect arrays
> aggregates join prepared_xacts
>      join                     ... FAILED
>      aggregates               ... FAILED
> parallel group (15 tests):  combocid portals_p2 advisory_lock xmlmap
> tsdicts guc functional_deps dependency select_views cluster tsearch
> window foreign_data foreign_key bitmapops
>      foreign_data             ... FAILED
> parallel group (19 tests):  limit prepare copy2 conversion xml plancache
> returning temp sequence without_oid with rowtypes truncate polymorphism
> domain largeobject rangefuncs alter_table plpgsql
>      alter_table              ... FAILED
> 

Fixed. The default value of TIMING option did not work as intended, it
was set to true even for plain EXPLAIN (without ANALYZE). In that case
the EXPLAIN failed.

Tomas

In response to

• Review of: explain / allow collecting row counts without timing info at 2012-01-13 17:07:03 from Josh Berkus

Responses

• Re: Review of: explain / allow collecting row counts without timing info at 2012-01-22 03:32:22 from Jeff Janes

pgsql-hackers by date

Next:	From: Andrew Dunstan	Date: 2012-01-13 23:07:43
	Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Previous:	From: Dimitri Fontaine	Date: 2012-01-13 22:53:32
	Subject: Re: Command Triggers