Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8().

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8().
Date: 2012-01-05 22:06:54
Message-ID: 4F061EFE.1070203@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 01/05/2012 12:05 PM, Andrew Dunstan wrote:
> Work around perl bug in SvPVutf8().
>
> Certain things like typeglobs or readonly things like $^V cause
> perl's SvPVutf8() to die nastily and crash the backend. To avoid
> that bug we make a copy of the object, which will subsequently be
> garbage collected.
>
> Back patched to 9.1 where we first started using SvPVutf8().
>
> Per -hackers discussion. Original problem reported by David Wheeler.
>

Ugh. This broke the regression tests. I'll get it fixed.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2012-01-05 22:30:09 Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8().
Previous Message Peter Eisentraut 2012-01-05 19:14:21 pgsql: pg_dump: Dump foreign options in prettier format

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2012-01-05 22:09:44 Re: our buffer replacement strategy is kind of lame
Previous Message David E. Wheeler 2012-01-05 21:47:58 Re: PL/Perl Does not Like vstrings