Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: pg_regress: Replace exit_nicely() with exit() plus atexit() hook

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: pg_regress: Replace exit_nicely() with exit() plus atexit() hook
Date: 2012-01-03 23:43:25
Message-ID: 4F03929D.4080207@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers

On 01/03/2012 06:29 PM, Peter Eisentraut wrote:
>
>>> I think there is some room for improvement there:
>>>
>>> - Why is the isolation test not part of check-world/installcheck-world?
>>
>> The buildfarm does not use the -world targets, for several reasons,
>> including:
> That was not my question.  I run check-world/installcheck-world locally,
> and if the isolation test had been part of this, this problem wouldn't
> have happened.


I have no idea why. It was probably an oversight when the isolation 
tests were added. I guess something like this would fix it?

    diff --git a/GNUmakefile.in b/GNUmakefile.in
    index 50fae41..5976832 100644
    --- a/GNUmakefile.in
    +++ b/GNUmakefile.in
    @@ -68,7 +68,7 @@ check installcheck installcheck-parallel:

    $(call recurse,check-world,src/test src/pl src/interfaces/ecpg
    contrib,check)

    -$(call recurse,installcheck-world,src/test src/pl
    src/interfaces/ecpg contrib,installcheck)
    +$(call recurse,installcheck-world,src/test src/test/isolation
    src/pl src/interfaces/ecpg contrib,installcheck)

    $(call recurse,maintainer-check,doc src config contrib)


The isolation tests only run installcheck, not plain check. See the 
archives for details of why.


>>> - Could we get the buildfarm server to send out emails whenever a build
>>> fails?
>> This facility has been there for years
> Cool, maybe it could be advertised on buildfarm.postgresql.org.  I
> couldn't see any link leading from there to anywhere near the mailing
> lists.
>
>


OK, I'll look at providing links from the web site to the lists.

cheers

andrew


In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-01-03 23:43:52
Subject: Re: [patch] Improve documentation around FreeBSD Kernel Tuning
Previous:From: Andrew DunstanDate: 2012-01-03 23:29:12
Subject: Re: [patch] Improve documentation around FreeBSD Kernel Tuning

pgsql-committers by date

Next:From: Robert HaasDate: 2012-01-04 02:00:01
Subject: Re: Re: [COMMITTERS] pgsql: pg_regress: Replace exit_nicely() with exit() plus atexit() hook
Previous:From: Peter EisentrautDate: 2012-01-03 23:29:05
Subject: Re: Re: [COMMITTERS] pgsql: pg_regress: Replace exit_nicely() with exit() plus atexit() hook

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group