Re: Review of VS 2010 support patches

From: Brar Piening <brar(at)gmx(dot)de>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review of VS 2010 support patches
Date: 2011-12-28 04:09:15
Message-ID: 4EFA966B.9080506@gmx.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Brar Piening wrote:
> I have to admit that it's currently broken (it builds but fails during
> regression tests becuse it can't connect) when building with Visual
> Studio 2010 or Windows SDK 7.1 because of commit
> 1a0c76c32fe470142d3663dd84ac960d75a4e8db (Enable compiling with the
> mingw-w64 32 bit compiler).
>
> It seems like VS 2010 has a few of the E... constants in
> src/include/port/win32.h already defined, but obviously in a way that
> breaks postgres.
>
> Because of my missing experience and as I don't have a Mingw64 build
> environment I don't feel like I could fix that without breaking
> anythig else.

I'd like to add that I'm certainly willing to test suggested fixes or
patches in my VS 2010 build environment.

Regards,
Brar

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2011-12-28 05:30:53 Re: Collect frequency statistics for arrays
Previous Message YAMAMOTO Takashi 2011-12-28 03:48:02 ordering op for WHERE