Skip site navigation (1) Skip section navigation (2)

Re: Review of VS 2010 support patches

From: Brar Piening <brar(at)gmx(dot)de>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review of VS 2010 support patches
Date: 2011-12-27 00:54:24
Message-ID: 4EF91740.4030301@gmx.de (view raw or flat)
Thread:
Lists: pgsql-hackers
Andrew Dunstan wrote:
> Well, I do also dislike the asymmetry of it. Here's what I suggest: 
> for the Solution files, we'll just put the object packages in 
> Solution.pm. There really doesn't seem like any need for those to have 
> tiny files on their own. For the Project files, factor out the 
> 2005/2008 specific parts from Project.pm into a new file, and have a 
> new file for the equivalent parts of your new VC2010Project.pm. Then 
> we'll add packages to Project.pm to create objects just like I'm 
> suggesting above for Solution.pm. The result is then more symmetrical 
> and we'll have three new files instead of seven (counting 
> VSObjectFactory.pm).
>
> Perhaps, too, this has all got sufficiently  complicated that adding 
> some descritpion of what's going on here to README would be in order. 
> I suspect some of my fellow committers tend to look at the whole thing 
> and scratch their heads a bit, and that means expecting other people 
> to make sense if it is probably a bit much ;-)

Attached is an updated patch which includes your suggestions.

I have to admit that it's currently broken (it builds but fails during 
regression tests becuse it can't connect) when building with Visual 
Studio 2010 or Windows SDK 7.1 because of commit 
1a0c76c32fe470142d3663dd84ac960d75a4e8db (Enable compiling with the 
mingw-w64 32 bit compiler).

It seems like VS 2010 has a few of the E... constants in 
src/include/port/win32.h already defined, but obviously in a way that 
breaks postgres.

Because of my missing experience and as I don't have a Mingw64 build 
environment I don't feel like I could fix that without breaking anythig 
else.

Regards,

Brar

Attachment: VS2010v11.patch
Description: text/plain (66.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2011-12-27 01:18:03
Subject: Re: contrib/README
Previous:From: Alvaro HerreraDate: 2011-12-26 23:00:00
Subject: Re: Adding XSLT support to PostgreSQL core?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group