Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]
Date: 2011-12-19 16:18:43
Message-ID: 4EEF63E3.2010602@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-bugs
On 19.12.2011 17:25, Tom Lane wrote:
> Heikki Linnakangas<heikki(dot)linnakangas(at)enterprisedb(dot)com>  writes:
>> On 19.12.2011 16:31, Robert Haas wrote:
>> Actually, I believe our Itanium (and possibly ARM, too) implementation
>> of S_UNLOCK() is wrong as it is.
>
> Hmm.  Anybody got a large itanium box we could play with?  If it is
> wrong, I'd expect it would show up pretty quickly under pgbench or
> similar.

We've been running pgbench heavily recently in the company on large HP 
Itanium boxes with 32 and 64 cores, and haven't seen any issues. I'm not 
sure how it would manifest itself, though. It's also possible that while 
it's a genuine bug at the source level, it happens to be masked by some 
compiler decisions. It sure looks wrong.

I'll try to construct a self-contained test program to exercise that.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

pgsql-bugs by date

Next:From: Martin PittDate: 2011-12-19 17:11:45
Subject: [PATCH v2] Use CC atomic builtins as a fallback
Previous:From: Alvaro HerreraDate: 2011-12-19 16:12:24
Subject: Re: BUG #6346: unsubscribe doesn't work

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group