From: | Greg Smith <greg(at)2ndQuadrant(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: includeifexists in configuration file |
Date: | 2011-12-16 06:02:06 |
Message-ID: | 4EEADEDE.4050602@2ndQuadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/15/2011 08:16 PM, Andrew Dunstan wrote:
> I changed the elog() call to use ereport(): you're not supposed to
> use elog() for things we expect might well happen and cause log
> entries - see bottom of
> <http://www.postgresql.org/docs/current/static/error-message-reporting.html>.
> I've probably been guilty of this in the past, it's a bit too easy to
> forget.
Quite, I both knew this once and forgot it last night. There was some
nagging in the back of my head that I was doing something wrong, but I
couldn't place what. Happy this is committed, given that I've suggested
relying upon it in the recovery.conf thread.
--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.us
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2011-12-16 06:21:35 | Re: Patch to allow users to kill their own queries |
Previous Message | Robert Haas | 2011-12-16 04:35:46 | Re: Storing hot members of PGPROC out of the band |