Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Revert the behavior of inet/cidr functions to not unpack the arg

From: Rafael Martinez <r(dot)m(dot)guerrero(at)usit(dot)uio(dot)no>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, r(dot)m(dot)guerrero(at)usit(dot)uio(dot)no
Subject: Re: pgsql: Revert the behavior of inet/cidr functions to not unpack the arg
Date: 2011-12-12 19:53:09
Message-ID: 4EE65BA5.5050501@usit.uio.no (view raw or flat)
Thread:
Lists: pgsql-committers
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/12/2011 07:55 PM, Andres Freund wrote:
> On Monday, December 12, 2011 07:48:01 PM Tom Lane wrote:
>> Andres Freund <andres(at)anarazel(dot)de> writes:
>>> On Monday, December 12, 2011 09:29:23 AM Heikki Linnakangas wrote:
>>>> Revert the behavior of inet/cidr functions to not unpack the arguments.
>>>
>>> Whats the plan to handle this wrt a stable release?
>>
>> I was wondering whether we shouldn't revert the original patch
>> altogether in the back branches.  As far as I'd heard, there were
>> no reports of the previous coding causing real trouble, and this
>> episode demonstrates that there is a possibility to make things
>> worse rather than better.  I think maybe we'd better treat this
>> change as something to make in HEAD only.
>
> +1

+1

This is a bug that really qualifies for an early 9.1.3.

A simple create index on an inet column almost crashed our production
server and everything got very unresponsive for a while.

The process running the create index grew to over 24GB in a matter of a
few minuttes. We managed to kill the process at the last moment before
going empty for cached memory and swap.

regards,
- -- 
 Rafael Martinez Guerrero
 Center for Information Technology
 University of Oslo, Norway

 PGP Public Key: http://folk.uio.no/rafael/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7mW50ACgkQBhuKQurGihTm8QCgmgIa8GVXfmLDjX68Gu460vZz
yuoAn2grjPPxcyBsVzetxpXJmnK9I0qE
=07YX
-----END PGP SIGNATURE-----

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2011-12-12 21:22:52
Subject: pgsql: Move BKP_REMOVABLE bit from individual WAL records to WAL pageh
Previous:From: Andres FreundDate: 2011-12-12 18:55:36
Subject: Re: pgsql: Revert the behavior of inet/cidr functions to not unpack the arg

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group