Re: [COMMITTERS] pgsql: plpython: Add SPI cursor support

From: Jan Urbański <wulczer(at)wulczer(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: plpython: Add SPI cursor support
Date: 2011-12-07 10:41:03
Message-ID: 4EDF42BF.6070204@wulczer.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 07/12/11 11:16, Jan Urbański wrote:
> On 06/12/11 19:33, Jan Urbański wrote:
>> On 06/12/11 19:23, Tom Lane wrote:
>>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>>> plpython: Add SPI cursor support
>>>
>>> Buildfarm member narwhal does not like this patch. It looks like
>>> "PyObject_SelfIter" is not a compile-time constant on its version
>>> of python (2.5, apparently).
>>
>> I'll try to dig around to see what can be causing that...
>
> Seems that PyObject_GenericGetIter has been renamed to PyObject_SelfIter
> at some point:
>
> http://hg.python.org/cpython/rev/fd5ef7003469
>
> I'm trying to muster whatever mercurial-foo I have to check if there's
> been a 2.5 version tagged without that patch...

So no, the renaming happened on Mar 17 2003 and 2.5 was tagged on
Sep 18 2006. The source tarball for 2.5 contains PyObject_SelfIter.

Both fennec and mastodon build OK with Python 2.5. Is it possible that
narwhal's Python installation is in some way broken?

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2011-12-07 11:20:18 pgsql: Avoid using readlink() on platforms that don't support it
Previous Message Jan Urbański 2011-12-07 10:16:54 Re: [COMMITTERS] pgsql: plpython: Add SPI cursor support

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2011-12-07 11:05:18 Re: Configuration include directory
Previous Message Jan Urbański 2011-12-07 10:16:54 Re: [COMMITTERS] pgsql: plpython: Add SPI cursor support