Re: splitting plpython into smaller parts

From: Jan Urbański <wulczer(at)wulczer(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Greg Smith <greg(at)2ndQuadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: splitting plpython into smaller parts
Date: 2011-12-05 23:58:16
Message-ID: 4EDD5A98.3000506@wulczer.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Rebased against master after the SPI cursor patch has been committed.

The first patch removes SPI boilerplate from the cursor functions as
well and the second patch creates a plpython_cursor.c file.

A side effect of creating a separate file for cursors is that I had to
make PLy_spi_transaction_{begin,commit,abort} helper functions external
since they're used both by regular SPI execution functions and the
cursor functions.

They live the plpython_spi.c which is not an ideal place for them, but
IMHO it's not bad either.

Cheers,
Jan

Attachment Content-Type Size
01-plpython-spi-boilerplate.patch.gz application/gzip 2.3 KB
02-plpython-split.patch.gz application/gzip 63.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-12-06 03:36:24 pull_up_simple_subquery
Previous Message Andrew Dunstan 2011-12-05 23:27:29 Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64