Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: NISHIYAMA Tomoaki <tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Date: 2011-12-04 00:45:49
Message-ID: 4EDAC2BD.9080409@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers

On 12/03/2011 06:12 PM, Andrew Dunstan wrote:
>
>
> On 12/03/2011 09:59 AM, Magnus Hagander wrote:
>> On Sat, Dec 3, 2011 at 15:49, NISHIYAMA Tomoaki
>> <tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp>  wrote:
>>> Hi,
>>>
>>>> Have you verified if tihs affects _MSC_VER<  1400? Suddently that
>>>> branch would care about HAVE_CRTDEFS_H, and I'm not sure if that's
>>>> something we need to worry about.
>>>
>>> I have no MSVC. In that sense it is not verified in fact, and I hope
>>> those who knows well would kindly comment on it.
>>>
>>> However, it appears that pg_config.h is not created through
>>> configure, but just copied from pg_config.h.win32 in those
>>> compilers and thus HAVE_CRTDEFS_H will not be defined.
>>> So, I think this code fragment will not be enabled in
>>> _MSC_VER<  1400
>> Hmm, true. Unless HAVE_CRTDEFS_H is defined by the sytem, which it
>> likely isn't - I was confusing it with the kind of defines that MSVC
>> tends to stick in their own headerfiles, and thought that's what you
>> were testing for.
>>
>
>
> Yes, but there's a deal more work to do here. This whole thing is 
> falling over in my build environment (64 bit Windows 7, MinGW/MSys, 
> the machine that runs pitta on the buildfarm.)
>
> This is a long way from a done deal.


In particular, it's a major mess because it does this (or at least the 
version I'm using does):

    #define stat _stat64


which plays merry hell with pgwin32_safestat(). Working around that 
looks very unpleasant indeed.


cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Andres FreundDate: 2011-12-04 01:09:08
Subject: Re: Command Triggers
Previous:From: Bruce MomjianDate: 2011-12-03 23:43:00
Subject: Moving tablespaces

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group