Re: splitting plpython into smaller parts

From: Jan Urbański <wulczer(at)wulczer(dot)org>
To: Greg Smith <greg(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: splitting plpython into smaller parts
Date: 2011-11-28 11:09:44
Message-ID: 4ED36BF8.3080001@wulczer.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 28/11/11 11:00, Greg Smith wrote:
> On 11/13/2011 09:45 AM, Jan Urbański wrote:
>> The second one is the actual split. plpython.c has been split into 11
>> separate files and one header.
>
> Could you comment a bit more about what the goal of this is? We don't
> have a reviewer for this patch yet, and I think part of the reason is
> because it's not really obvious what it's supposed to be doing, and why
> that's useful.

The idea of splitting plpython.c (an almost 5k lines file) into
something more modular.

It's been floated around here:

http://postgresql.1045698.n5.nabble.com/Large-C-files-tt4766446.html#a4773493

and I think at other occasions, too.

The patch introduces no behavioural changes, it's only shuffling code
around. The only goal is to improve the maintainability.

I guess the reviewer could verify that a) I haven't botched the split
and it all still compiles and workds b) the choice of which modules were
defined is correct

Cheers,
Jan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shigeru Hanada 2011-11-28 11:50:27 Re: pgsql_fdw, FDW for PostgreSQL server
Previous Message Shigeru Hanada 2011-11-28 11:00:23 Re: pgsql_fdw, FDW for PostgreSQL server