Skip site navigation (1) Skip section navigation (2)

Re: Sign me up

From: Greg Smith <greg(at)2ndQuadrant(dot)com>
To: pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: Sign me up
Date: 2011-11-15 01:52:56
Message-ID: 4EC1C5F8.2030109@2ndQuadrant.com (view raw or flat)
Thread:
Lists: pgsql-rrreviewers
On 11/14/2011 04:17 PM, Royce Ausburn wrote:
> Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of months ago ;)  I'm not strong in C either, but I'll nut it out.
>    

How about "Include detailed information about a row failing a CHECK 
constraint into the error message"?  There's not a lot of code there, 
the main review work is preparing a test case that demonstrates the code 
does its job.  (One really should have been included with the patch, but 
this condition isn't difficult to recreate)  If that sounds reasonable, 
just edit the patch and add yourself there.  I see you've already 
created your own entry there, so you know how that works.

-- 
Greg Smith   2ndQuadrant US    greg(at)2ndQuadrant(dot)com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support  www.2ndQuadrant.us


In response to

  • Sign me up at 2011-11-14 21:17:58 from Royce Ausburn

Responses

pgsql-rrreviewers by date

Next:From: Royce AusburnDate: 2011-11-15 02:15:40
Subject: Re: Sign me up
Previous:From: Royce AusburnDate: 2011-11-14 21:17:58
Subject: Sign me up

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group