| From: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
|---|---|
| To: | <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | warning in pg_upgrade |
| Date: | 2011-10-31 16:59:55 |
| Message-ID: | 4EAE8DBB02000025000428A9@gw.wicourts.gov |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I just noticed a warning in pg_upgrade:
option.c: In function *parseCommandLine*:
option.c:96:8: warning: ignoring return value of *getcwd*,
declared
with attribute warn_unused_result
It looks like it might be worth testing the return value here for
NULL, which would indicate an error accessing the current working
directory. Untested patch attached for purposes of discussion.
http://www.kernel.org/doc/man-pages/online/pages/man3/getcwd.3.html
-Kevin
| Attachment | Content-Type | Size |
|---|---|---|
| getcwd-return-value.patch | text/plain | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-10-31 17:09:48 | Re: Multiple queries in transit |
| Previous Message | Marti Raudsepp | 2011-10-31 16:57:58 | Re: Multiple queries in transit |