Skip site navigation (1) Skip section navigation (2)

Re: Re: Optimizing pg_trgm makesign() (was Re: WIP: Fast GiST index build)

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <heikki(dot)linnakangas(at)enterprisedb(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: Optimizing pg_trgm makesign() (was Re: WIP: Fast GiST index build)
Date: 2011-09-26 02:32:27
Message-ID: 4E7F9DEB020000250004174F@gw.wicourts.gov (view raw or flat)
Thread:
Lists: pgsql-hackers
> Tom Lane  wrote:
> "Kevin Grittner"  writes:
>> This is a review of the patch at this CF location:
>> https://commitfest.postgresql.org/action/patch_view?id=598
>> as posted here:
>>
http://archives.postgresql.org/message-id/4E04C099.3020604@enterprisedb.com
>  
> Hmm, why is that patch the one posted for review, when several
> better versions were already discussed? See thread starting here:
> http://archives.postgresql.org/pgsql-hackers/2011-07/msg00028.php
 
The patch I reviewed was added to the CF app before the post you cite
was written.  I didn't see it in following the links (probably
because it crossed a month boundary).  Thanks for pointing that out;
I'll update the CF app and review the later versions.
 
-Kevin

Responses

pgsql-hackers by date

Next:From: Noah MischDate: 2011-09-26 02:38:18
Subject: Re: [v9.2] Fix Leaky View Problem
Previous:From: Peter GeogheganDate: 2011-09-26 02:12:55
Subject: Re: Inlining comparators as a performance optimisation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group