Re: Further news on Clang - spurious warnings
From:
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To:
Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc:
PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: Further news on Clang - spurious warnings
Date:
2011-08-03 09:34:26
Message-ID:
4E391622.90802@enterprisedb.com (view raw or flat )
Thread:
2011-08-02 23:52:17 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-03 08:47:07 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-03 09:25:31 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-03 09:34:26 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2011-08-03 10:05:52 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-03 10:40:42 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2011-08-04 01:21:17 from David Fetter <david(at)fetter(dot)org>
2011-08-04 05:59:07 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2011-08-03 11:13:20 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-03 11:19:29 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2011-08-03 11:44:40 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-03 13:30:37 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-03 14:29:09 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-08-03 15:31:10 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-03 20:03:39 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-08-03 22:28:38 from daveg <daveg(at)sonic(dot)net>
2011-08-03 22:58:51 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-04 06:08:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-08-04 08:53:01 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-04 20:49:22 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-05 16:12:17 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-08-05 17:57:13 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-05 18:52:32 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-05 19:07:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-08-06 12:45:01 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2011-08-06 18:58:07 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-08-13 21:49:25 from Greg Stark <stark(at)mit(dot)edu>
2011-08-03 18:15:37 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2011-08-03 17:33:03 from "David E(dot) Wheeler" <david(at)kineticode(dot)com>
2011-08-03 18:17:33 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2011-08-03 18:20:49 from "David E(dot) Wheeler" <david(at)kineticode(dot)com>
2011-08-03 18:28:19 from Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl>
2011-08-03 19:21:28 from "David E(dot) Wheeler" <david(at)kineticode(dot)com>
2011-08-12 18:46:16 from "David E(dot) Wheeler" <david(at)kineticode(dot)com>
2011-08-12 19:09:55 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2011-08-12 19:10:51 from "David E(dot) Wheeler" <david(at)kineticode(dot)com>
2011-08-12 19:33:49 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Lists:
pgsql-hackers
On 03.08.2011 12:25, Peter Geoghegan wrote:
> Attached patch removes the tautologolical part of an evaluated
> expression, fixing the problem flagged by this quite valid warning.
The check is only tautological if the compiler implements enums as
unsigned integers. Whether enums are signed or not is
implementation-dependent. Perhaps cast status to unsigned or signed
explicitly before the checks?
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
In response to
Responses
pgsql-hackers by date
Next :From: Peter GeogheganDate: 2011-08-03 10:05:52Subject : Re: Further news on Clang - spurious warningsPrevious :From : Peter GeogheganDate : 2011-08-03 09:25:31Subject : Re: Further news on Clang - spurious warnings
