| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: Small patch for GiST: move childoffnum to child |
| Date: | 2011-07-10 18:43:14 |
| Message-ID: | 4E19F2C2.9010001@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Teodor, Oleg, Heikki,
> My concern is that I am unable to prove to myself simply by reading
> the code that the 24 line chunk deleted from gistFindPath (near ***
> 919,947 ****) are no longer needed. My familiarity with the gist code
> is low enough that it is not surprising that I cannot prove this to
> myself from first principles. I have no reason to believe it is not
> correct, it is just that I can't convince myself that it is correct.
Can one of you weigh in on Jeff's concern here about this patch?
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2011-07-10 18:44:28 | Re: Re: patch review : Add ability to constrain backend temporary file space |
| Previous Message | Josh Berkus | 2011-07-10 18:40:54 | Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected |