Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Adjust OLDSERXID_MAX_PAGE based on BLCKSZ.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Subject: Re: [COMMITTERS] pgsql: Adjust OLDSERXID_MAX_PAGE based on BLCKSZ.
Date: 2011-07-08 09:26:54
Message-ID: 4E16CD5E.9060303@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On 07.07.2011 22:09, Robert Haas wrote:
> Adjust OLDSERXID_MAX_PAGE based on BLCKSZ.
>
> The value when BLCKSZ = 8192 is unchanged, but with larger-than-normal
> block sizes we might need to crank things back a bit, as we'll have
> more entries per page than normal in that case.

I'm getting a bunch of warnings on Windows related to this:

>   .\src\backend\storage\lmgr\predicate.c(768): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(768): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(769): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(769): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(770): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(770): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(770): warning C4146: unary minus operator applied to unsigned type, result still unsigned
>   .\src\backend\storage\lmgr\predicate.c(771): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(771): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(826): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(826): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(846): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(846): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(851): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(851): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(909): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(909): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(956): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(956): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(1036): warning C4307: '+' : integral constant overflow
>   .\src\backend\storage\lmgr\predicate.c(1036): warning C4307: '+' : integral constant overflow

I'm not sure if these are harmless or not.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

pgsql-hackers by date

Next:From: Alexander KorotkovDate: 2011-07-08 09:32:39
Subject: Re: WIP: Fast GiST index build
Previous:From: Kyotaro HORIGUCHIDate: 2011-07-08 09:21:16
Subject: Re: make_greater_string() does not return a string in some cases

pgsql-committers by date

Next:From: Peter EisentrautDate: 2011-07-08 14:15:19
Subject: pgsql: Add item about Clang support to 9.1 release notes
Previous:From: Peter EisentrautDate: 2011-07-08 04:43:51
Subject: pgsql: Message style improvements

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group