Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc
Date: 2011-05-25 05:22:03
Message-ID: 4DDC91FB.7040008@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-committers
On 25.05.2011 00:58, Tom Lane wrote:
> Heikki Linnakangas<heikki(dot)linnakangas(at)enterprisedb(dot)com>  writes:
>> On 22.05.2011 21:18, Tom Lane wrote:
>>> I'm also concerned that you've probably
>>> added cycles on net to MemoryContextAlloc (where it's no longer possible
>>> to tail-call AllocSetAlloc), which could very easily cost more cycles on
>>> most workloads than could ever be saved by making MemoryContextReset a
>>> shade faster.
>
>> Good point. That would be solved by clearing the flag before the
>> AllocSetAlloc() call. I don't see any harm in clearing the flag before
>> actually doing the allocation.
>
> Done that way.

Ok, thanks.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

pgsql-committers by date

Next:From: Peter EisentrautDate: 2011-05-25 18:55:35
Subject: pgsql: Put options in some sensible order
Previous:From: Andrew DunstanDate: 2011-05-25 04:21:42
Subject: pgsql: Convert builddoc.bat into a perl script that actually works.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group