| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc |
| Date: | 2011-05-25 05:22:03 |
| Message-ID: | 4DDC91FB.7040008@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 25.05.2011 00:58, Tom Lane wrote:
> Heikki Linnakangas<heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> On 22.05.2011 21:18, Tom Lane wrote:
>>> I'm also concerned that you've probably
>>> added cycles on net to MemoryContextAlloc (where it's no longer possible
>>> to tail-call AllocSetAlloc), which could very easily cost more cycles on
>>> most workloads than could ever be saved by making MemoryContextReset a
>>> shade faster.
>
>> Good point. That would be solved by clearing the flag before the
>> AllocSetAlloc() call. I don't see any harm in clearing the flag before
>> actually doing the allocation.
>
> Done that way.
Ok, thanks.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-05-25 18:55:35 | pgsql: Put options in some sensible order |
| Previous Message | Andrew Dunstan | 2011-05-25 04:21:42 | pgsql: Convert builddoc.bat into a perl script that actually works. |