| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Re: pgsql: setlocale() on Windows doesn't work correctly if the locale name |
| Date: | 2011-04-20 03:25:16 |
| Message-ID: | 4DAE521C.1050405@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 04/19/2011 09:42 PM, Hiroshi Inoue wrote:
>
> bootstrap_template1() in initdb runs the BKI script in bootstrap
> mode to create template1. Some symbols (LC_COLLATE, LC_CTYPE in
> pg_database etc) in the BKI script are substituted by actual values
> using replace_token(). Isn't it correct?
> ISTM replace_token() takes care of nothing about single quotes
> in its input values but the comment in scanstr() says
> /*
> * Note: if scanner is working right, unescaped
> quotes can only
> * appear in pairs, so there should be another
> character.
> */
>
That's perfectly true, but only one of the replaced locale names
contains a single quote mark. So clearly there's more going on here than
just the bug you're referring to. Heikki's commit message specifically
refers to dots in locale names, which shouldn't cause a problem of that
type, I believe.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hiroshi Inoue | 2011-04-20 03:48:14 | Re: [HACKERS] Re: pgsql: setlocale() on Windows doesn't work correctly if the locale name |
| Previous Message | Hiroshi Inoue | 2011-04-20 01:42:35 | Re: [HACKERS] Re: pgsql: setlocale() on Windows doesn't work correctly if the locale name |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hiroshi Inoue | 2011-04-20 03:48:14 | Re: [HACKERS] Re: pgsql: setlocale() on Windows doesn't work correctly if the locale name |
| Previous Message | Robert Haas | 2011-04-20 02:47:16 | time-delayed standbys |