Skip site navigation (1) Skip section navigation (2)

Re: Disable optimization when in subtransaction

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <pgsql-hackers(at)postgresql(dot)org>, "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: "Dan Ports" <drkp(at)csail(dot)mit(dot)edu>
Subject: Re: Disable optimization when in subtransaction
Date: 2011-04-04 18:57:46
Message-ID: 4D99CE5A020000250003C235@gw.wicourts.gov (view raw or flat)
Thread:
Lists: pgsql-hackers
"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> When I was investigating this report:
>  
> http://archives.postgresql.org/pgsql-bugs/2011-03/msg00349.php
>  
> besides providing a straightforward fix here:
>  
> http://archives.postgresql.org/pgsql-bugs/2011-03/msg00352.php
>  
> I noted that there was nearby code which needed review, as it
> didn't seem safe when in a subtransaction.  Further review
> confirmed this and didn't turn up any other problems in that
> section of code. So, a fix for this overreaching optimization is
> attached.  Note that it is a one-line fix except for some
> additional comments to explain the limitation.
>  
> This patch is in addition to and orthogonal to the first patch
> cited above.
>  
> I will add this one to the 9.1 open items list.
 
I managed to get a one-line patch wrong.  Sorry.  2nd try.
 
-Kevin


Attachment: ssi-subtransaction-no-optimization-v2.patch
Description: text/plain (1.6 KB)

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2011-04-04 18:58:31
Subject: Re: GUC assign hooks (was Re: wal_buffers = -1 and SIGHUP)
Previous:From: Robert HaasDate: 2011-04-04 18:56:25
Subject: Re: time table for beta1

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group