On 30.03.2011 21:21, Jan Urbański wrote:
> Valgrind showed me the way. PFA a trivial patch to avoid leaking a
> PLyProcedure struct in inline blocks.
Hmm, any reason the PLyProcedure struct needs to be allocated in
TopMemoryContext in the first place? Could you palloc0 it in a
shorter-lived context, or even better, just allocate it in stack?
PS. I don't think the volatile qualifier in 'proc' is in necessary. The
variable is not changed in PG_TRY-block.
In response to
pgsql-hackers by date
|Next:||From: Heikki Linnakangas||Date: 2011-03-31 07:20:32|
|Subject: Re: Replication server timeout patch|
|Previous:||From: Brendan Jurd||Date: 2011-03-31 03:39:25|
|Subject: Re: [HACKERS] Date conversion using day of week|
pgsql-committers by date
|Next:||From: Heikki Linnakangas||Date: 2011-03-31 07:10:50|
|Subject: pgsql: Improve error message when WAL ends before reaching end ofonlin|
|Previous:||From: Bruce Momjian||Date: 2011-03-30 21:46:21|
|Subject: pgsql: Mention pg_upgrade sets autovacuum_freeze_max_age to maximum.|