| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Thom Brown <thom(at)linux(dot)com>, pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: Support for invalid foreign keys |
| Date: | 2011-03-07 20:58:57 |
| Message-ID: | 4D754711.8060603@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Le 07/03/2011 07:49, Dave Page a écrit :
> On Mon, Mar 7, 2011 at 6:21 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Well, it was supposed to be deleted. Actually, I was supposed to ask if
>> anyone knows why there is the "if (sql.IsNull())" check at all (the "||
>> forceRefresh" is a test I should have deleted). I have no idea why there
>> is this sql.IsNull() test. It doesn't appear in other same sources.
>> Dave, any idea?
>
> It's an optimisation to prevent us regenerating the SQL every time we
> need it. For most objects that's cheap - for some (eg. tables) - far
> from it.
>
> When refreshing, frmMain->Refresh calls the SetDirty() function on the
> object, which causes sql to be cleared ready for regeneration.
>
OK, commited with a few fixes according to this discussion. Thanks.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2011-03-07 21:01:53 | pgAdmin III commit: Support for Foreign Data Wrapper object. |
| Previous Message | pgAdmin Trac | 2011-03-07 20:58:32 | Re: [pgAdmin III] #304: Add support for invalid FK constraints |