Skip site navigation (1) Skip section navigation (2)

Re: SSI patch version 14

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: simon(at)2ndQuadrant(dot)com, markus(at)bluegap(dot)ch, pgsql-hackers(at)postgresql(dot)org
Subject: Re: SSI patch version 14
Date: 2011-02-02 17:41:35
Message-ID: 4D49974F.4070403@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On 02.02.2011 19:36, Kevin Grittner wrote:
> Heikki Linnakangas  wrote:
>
>> Suppressing detail seems easiest. AFAICS all the variable parts are
>> in errdetail.
>
> I pushed that with some work on the tests.  If you could review the
> changes to isolationtester.c to confirm that they look sane, I'd
> appreciate it.
>
> http://git.postgresql.org/gitweb?p=users/kgrittn/postgres.git;a=commitdiff;h=2e0254b82a62ead25311f545b0626c97f9ac35b4#patch6
>
> If that part is right, it shouldn't take me very long to finish the
> specs and capture the expected results.

Looks good. A comment would be in order to explain why we only print the 
primary message. (yeah, I know I didn't comment the tester code very 
well myself)

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

pgsql-hackers by date

Next:From: Jeff DavisDate: 2011-02-02 17:55:34
Subject: Re: WIP: RangeTypes
Previous:From: Kevin GrittnerDate: 2011-02-02 17:36:31
Subject: Re: SSI patch version 14

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group