Skip site navigation (1) Skip section navigation (2)

Re: Move WAL warning

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Move WAL warning
Date: 2011-02-02 16:43:59
Message-ID: 4D4989CF.3090009@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On 02.02.2011 16:36, Magnus Hagander wrote:
> When running pg_basebackup with -x to include all transaction log, the
> server will still throw a warning about xlog archiving if it's not
> enabled - that is completely irrelevant since pg_basebackup has
> included it already (and if it was gone, the base backup step itself
> will fail - actual error and not warning).
>
> This patch moves the warning from do_pg_base_backup to pg_base_backup,
> so it still shows when using the explicit function calls, but goes
> away when using pg_basebackup.

For the sake of consistency, how about moving the "pg_stop_backup 
complete, all required WAL segments have been archived" notice too?

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Tim BunceDate: 2011-02-02 16:45:52
Subject: Re: Optimize PL/Perl function argument passing [PATCH]
Previous:From: Bruce MomjianDate: 2011-02-02 16:09:56
Subject: Re: A postgres parser related question

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group