Skip site navigation (1) Skip section navigation (2)

Re: SSI patch version 14

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Markus Schiltknecht <markus(at)bluegap(dot)ch>
Subject: Re: SSI patch version 14
Date: 2011-02-02 12:56:55
Message-ID: 4D495497.8050704@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On 02.02.2011 12:20, Heikki Linnakangas wrote:
> On 26.01.2011 13:36, Simon Riggs wrote:
>> I looked at the patch to begin a review and immediately saw "dtest".
>> There's no docs to explain what it is, but a few comments fill me in a
>> little more. Can we document that please? And/or explain why its an
>> essential part of this commit? Could we keep it out of core, or if not,
>> just commit that part separately? I notice the code is currently
>> copyright someone else than PGDG.
>
> We still haven't really resolved this..
>
> Looking at the dtest suite, I'd really like to have those tests in the
> PostgreSQL repository. However, I'd really like not to require python to
> run them, and even less dtester (no offense Markus) and the dependencies
> it has. I couldn't get it to run on my basic Debian system, clearly I'm
> doing something wrong, but it will be even harder for people on more
> exotic platforms.
>
> The tests don't seem very complicated, and they don't seem to depend
> much on the dtester features. How hard would it be to rewrite the test
> engine in C or perl?
>
> I'm thinking of defining each test in a simple text file, and write a
> small test engine to parse that.

I took a stab at doing that. Attached, untar in the top source tree, and 
do "cd src/test/isolation; make check". It's like "installcheck", so it 
needs a postgres server to be running. Also available in my git 
repository at git://git.postgresql.org/git/users/heikki/postgres.git, 
branch "serializable".

I think this will work. This is a rough first version, but it already 
works. We can extend the test framework later if we need more features, 
but I believe this is enough for all the existing tests.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

Attachment: isolationtester.tar.gz
Description: application/x-gzip (5.7 KB)

In response to

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2011-02-02 13:04:28
Subject: Re: SSI patch version 14
Previous:From: Markus WannerDate: 2011-02-02 12:48:54
Subject: Re: SSI patch version 14

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group