Skip site navigation (1) Skip section navigation (2)

Re: pgAdmin III: crash when trying to save edited pg_hba.conf

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Nikhil S <nixmisc(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III: crash when trying to save edited pg_hba.conf
Date: 2011-01-28 22:39:11
Message-ID: 4D43458F.4080302@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Le 28/01/2011 10:18, Nikhil S a écrit :
> Hi,
> 
> The following set of operations induce a crash in the latest git code base:
> 
> 1. Open pgAdmin III
> 2. Go to File Menu->Open Postgressql.conf
> 3. From data folder select pg_hba.conf file and open it
> 4. The file opens successfully
> 5. Now select any setting ("port" for example) and add a Value and Comment
> to it
> 6. A save of this induces a crash
> 
> The issue appears to be in the dlgMainConfig::dlgMainConfig() function. If
> there is no old setting present, the item->newLine object uses the default
> constructor. This does not set the item->newLine->item field at all.
> 
> While eventually saving this via frmMainConfig::WriteFile() function, we end
> up accessing the null "item" field causing this segmentation fault. The fix
> is to set this field properly inside the dlgMainConfig call above. Is my
> reasoning and the attached fix correct? Please let me know.
> 

Seems good enough. Commited. Thanks a lot :)


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2011-01-28 22:40:50
Subject: Re: pgAdmin III commit: Fix copy bug in the edit grid
Previous:From: Guillaume LelargeDate: 2011-01-28 22:39:01
Subject: pgAdmin III commit: Fix a crash when trying to save an edited pg_hba

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group