Re: mingw format warnings

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: mingw format warnings
Date: 2011-01-28 22:28:43
Message-ID: 4D43431B.9020605@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/28/2011 03:11 PM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> We have had format warnings in mingw builds for years, and it doesn't
>> look like we're ever going to do anything about them. Can we just add
>> -Wno-format to the CFLAGS for Mingw and be done with them?
> Are any of them substantive, or are they all about %m ?

[andrew(at)aurelia ]$ grep 'warning.*format' frogmouth-make*.log | sed
's/.*warning:/warning:/' | sort | uniq -c
1 warning: format '%08x' expects type 'unsigned int', but
argument 3 has type 'DWORD'
1 warning: format '%0i' expects type 'int', but argument 4 has
type 'DWORD'
1 warning: format '%0i' expects type 'int', but argument 5 has
type 'DWORD'
1 warning: format '%-30s' expects type 'char *', but argument 6
has type 'int'
2 warning: format '%d' expects type 'int', but argument 3 has
type 'DWORD'
2 warning: format '%i' expects type 'int', but argument 3 has
type 'uint64'
2 warning: format '%i' expects type 'int', but argument 4 has
type 'uint64'
3 warning: format not a string literal and no format arguments
1 warning: format '%s' expects type 'char *', but argument 4 has
type 'int64'
70 warning: too many arguments for format
1 warning: unknown conversion type character 'G' in format
73 warning: unknown conversion type character 'l' in format
360 warning: unknown conversion type character 'm' in format
1 warning: unknown conversion type character 'V' in format

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-01-28 22:34:46 Re: mingw format warnings
Previous Message Alex Hunsaker 2011-01-28 22:27:06 Re: arrays as pl/perl input arguments [PATCH]